The Tournament Director Forums

Main => Beta Testing => Topic started by: Corey Cooper on October 12, 2019, 11:38:18 PM

Title: 3.7 BETA 1
Post by: Corey Cooper on October 12, 2019, 11:38:18 PM
Finally!

Version 3.7 BETA 1 is finally ready.  Remember it is a beta version, so there will be bugs found.  This is a little different from previous beta versions because there are a few things I know don't work, but they're not crucial to using the application.

OK, some notable things:

- When you install the new version there's no option to choose the installation folder.  This is done so the app does not need any elevated privileges, even at install time.

- Installing this new version will NOT upgrade your existing installed version.  It will install the new version only, with new shortcuts.  So if you currently have version 3.4.3 installed, after installing version 3.7 BETA 1 you will then have both 3.4.3 and 3.7 BETA 1 installed.

- No evaluation mode at this time.  It simply isn't done yet.  So to participate in this first beta you will need a license.

- Take a backup of your data first.  The new version will upgrade preferences, database, etc.  Take a backup so you can roll back to 3.x if you decide to.

I am super excited about this new version.  Please let me know how it works for you!  Reply to this post, create your own new post, or send email to support@thetournamentdirector.net.

Download the new version here:
Edit: Beta 2 is ready: https://www.thetournamentdirector.net/forums/index.php?topic=5931.0

For anyone wondering about the version numbering: based on https://www.thetournamentdirector.net/faq.html#faq4 I could not increase the major version from 3 to 4 because there is no significant new functionality.  At the same time, there has been so much change (under the covers) that a change from 3.4.3 -> 3.5 frankly seems dishonest.  Thus I picked the midpoint between 3.4 and 4.0.  Welcome to version 3.7.  :-)
Title: Re: 3.7 BETA 1
Post by: efdenny on October 13, 2019, 12:47:48 AM
Thanks, Corey... installing now! I'll let you know how it works for me...
Title: Re: 3.7 BETA 1
Post by: Carlavatky on October 13, 2019, 05:23:46 PM
Installed earlier and spent a few minutes with it. Let it run a simulated tournament for a few hours without any issues so far.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 13, 2019, 08:33:18 PM
Awesome, thanks for the update!

Installed earlier and spent a few minutes with it. Let it run a simulated tournament for a few hours without any issues so far.
Title: Re: 3.7 BETA 1
Post by: lolo02100 on October 14, 2019, 07:26:57 AM
Thanks, Corey
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 14, 2019, 10:17:28 AM
Corey, I loaded a saved tournament goto layout - design mode and load a screen that has a iframe reference - close the settings screen and wait for the green banner to disappear it seems to lockup, pressing esc or F11 does nothing. I tested this on other screens without iframe and everything seems to work.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 14, 2019, 02:02:31 PM
Hmm, how did you recover when it locked up?

I ask because I did discover one minor issue right after I released it, where when a window is closed the parent window doesn't immediately focus.  For some reason this doesn't happen on my Win7 PC or on one of my Win10 PCs, but does happen on another Win10 PC.  No idea why.  When you close the Settings window, and then try to open it again by pressing the ESC key, it could seem like it's locked up, but that's just because the main window doesn't have focus, so your ESC presses aren't received.  You just have to click on the window again to bring it back into focus.
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 14, 2019, 02:11:29 PM
I have to close the program and restart. I think you are right about losing focus but clicking anywhere on the screen does nothing.
I think it has something to do with iframe. I am going to try again with the same screen and then remove the iframe content and see if it changes.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 14, 2019, 02:17:33 PM
Yeah I had to do some work to get the iframes working properly, but context menus and hotkeys should work, even from the iframe.  Now, if your layout has embedded iframes in it, it might not.  It won't recursively dig down and find all iframes and try to make hotkeys and context menus work.  In fact, it can't, due to security restrictions.  If your layout has an iframe in it, it is considered from a different "domain" and access is limited.
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 14, 2019, 02:18:17 PM
OK, i just tried the same screen again and got the same result, I then removed the iframe reference and tried again and everything worked. Seems iframe is causing the problem. Let me know if there is something else you want me to try/do.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 14, 2019, 02:20:35 PM
Can you send me your layout?
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 14, 2019, 02:21:17 PM
yes,
sent
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 14, 2019, 02:34:53 PM
seems to be the sizing for the iframe ... a while ago i had trouble with positioning and was using a negative value for the top value. I just removed that value and can now click the top part of the screen to get to get esc to work. The iframe was covering the whole screen and clicking inside the iframe doesn't do anything. So it seems to be operator error instead of software error. 
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 14, 2019, 03:10:09 PM
I see.  HTML screens use an iframe to display.  If your HTML screen also has an iframe, context menus and hotkeys won't work when that frame has focus.  That's the security issue I was mentioning.  Handlers can't be attached to those iframes, so there's not much that can be done.  But, the Game window outside of the iframe should work fine.

So the next step would be to see if the iframe(s) in your layout are necessary.

FYI, did you send the layout to support@thetournamentdirector.net?  I didn't get anything.
Title: Re: 3.7 BETA 1
Post by: efdenny on October 14, 2019, 05:53:46 PM
simulated a few tournaments, ran stats, changed layouts... all good so far.
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 14, 2019, 06:36:34 PM
Odd ... Yes, that is where i sent it. I can resend if you still want it.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 14, 2019, 11:43:12 PM
I wouldn't mind verifying what you saw is not an actual issue.
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 15, 2019, 06:25:20 AM
I resent from a different email. let me know if you didnt receive it.
Title: Re: 3.7 BETA 1
Post by: Carlavatky on October 15, 2019, 07:53:09 AM
I started building a new layout last and noticed a couple of things.
 - My Surface Pro has a 2736 x 1824 (267 PPI) resolution. While working with a layout, the "Edit Cell" dialog buttons were nearly hidden and the dialog itself would not expand to reveal them.
 - In some cases when you highlight the token text in the "Edit Cell" dialog box, the "Insert Token" button will display green and change to "Edit Token" but this behavior isn't consistent and sometimes does not occur.
 - Changing the border size in the "Edit Cell Properties" form (Boarders sub form) has no effect.
 - The HTML that controls the STATS table display is hard coded to prevent cell alignment and cells have varying justification (some LH, some RH, some center) which causes some layout ugliness

Beta seems very stable so far. I have not experienced any crashes or lockups and I really like the simplicity of screen resizing and movement as compared to the old dialog. I'll report more if and when I see anything else as I play around
Title: Re: 3.7 BETA 1
Post by: NLAxeman on October 15, 2019, 11:38:58 AM
Tried the new Beta on my backup machine and it said my licence was not valid. Pretty sure I have a Ver 3 licence. Any advice?
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 15, 2019, 01:06:05 PM
Got it this time.  Thanks.  I'll check it out when I can.

I resent from a different email. let me know if you didnt receive it.
Title: Re: 3.7 BETA 1
Post by: shushs on October 15, 2019, 02:06:45 PM
So far, it looks pretty good. I did see a few things though.

1. Are you going to include 'The Poker Leaderboard' export again, or is that gone like the wind?
2. I had a weird 'bust out before rebuy period was over, and was prompted to rebuy' but subsequent busts were not prompted (still within the window and not exceeding the rebuy quota.
3. I defined two tables of 9 seats each, then added 6 players to a tournament. Then bought them in with autoseating. and there were 4 at one table, and 2 at another. If it were 3 and 3, that'd be understandable, but all at one table would be preferred.

I'm going to keep poking around, but that's my first report. And, just to follow up, if you need a linux/mac guy to test for you, I'm still willing. =)
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 15, 2019, 05:32:36 PM
First, thanks for your efforts.

- My Surface Pro has a 2736 x 1824 (267 PPI) resolution. While working with a layout, the "Edit Cell" dialog buttons were nearly hidden and the dialog itself would not expand to reveal them.

I was really excited about this release fixing the issues when Windows scaling is enabled.  And while it's miles beyond how the app behaved previously, it's not quite there yet.  I'm going to go with that this is a little bit of a Chromium issue, and a little bit of a TD issue.  For example, if you have Windows configured with scaling to, say, 150%, in the TD if you load a tournament (or any file) you'll see the file selection window isn't scaled like everything else is.  This is a Chromium issue.  However, in the version of Chrome I have installed (77.xxx I believe), the file selection window does indeed scale (I know for a fact it didn't with earlier versions).  The beta version of the TD uses Chromium 73.xxx.  Maybe things will improve with a newer version.  I will always try to upgrade to the latest Electron (and thus newer versions of Chromium, V8, Node, etc) with each new TD version.

- In some cases when you highlight the token text in the "Edit Cell" dialog box, the "Insert Token" button will display green and change to "Edit Token" but this behavior isn't consistent and sometimes does not occur.

I haven't really seen an issue with this.  The way it's supposed to work is that if you highlight any part of a token, and NOT any additional text, the token should be recognized and the button should light up.  For example, if you have:

<nobr>Current Time</nobr><br><currenttime showSeconds="t">

... and you highlight any part of:

<currenttime showSeconds="t">

... it should highlight the Edit Token button.  But if your highlighting includes any of the rest of the text, the button won't be highlighted.  It could probably be made a little smarter, but that's how it works today.  Are you seeing something different?

- Changing the border size in the "Edit Cell Properties" form (Boarders sub form) has no effect.

Note that when you change the border's Type, Size, OR Color, you have to click on one of the border sides to implement that change.  This allows for the different borders (top, bottom, left and right) to have different characteristics.  Again, are you seeing something different?

- The HTML that controls the STATS table display is hard coded to prevent cell alignment and cells have varying justification (some LH, some RH, some center) which causes some layout ugliness

Per your other post, confirmed spacing is not working.  Justification is indeed hard-coded.  But there's no way to specify justification (left/center/right) on any screen, and there never has been.  I think once spacing is fixed this will look a lot better.

I also found a bug: on the Token Builder dialog, when the Edit button is pressed on a font, the font dialog opens twice.

Beta seems very stable so far. I have not experienced any crashes or lockups and I really like the simplicity of screen resizing and movement as compared to the old dialog. I'll report more if and when I see anything else as I play around

Thanks again for the time and effort!
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 15, 2019, 05:44:34 PM
Thanks for the help.

So far, it looks pretty good. I did see a few things though.

1. Are you going to include 'The Poker Leaderboard' export again, or is that gone like the wind?

As far as I know, they've been gone for a long time.  Years.

2. I had a weird 'bust out before rebuy period was over, and was prompted to rebuy' but subsequent busts were not prompted (still within the window and not exceeding the rebuy quota.

Thanks for the report.  I'm also seeing this every once in a while.

3. I defined two tables of 9 seats each, then added 6 players to a tournament. Then bought them in with autoseating. and there were 4 at one table, and 2 at another. If it were 3 and 3, that'd be understandable, but all at one table would be preferred.

I'm going to keep poking around, but that's my first report. And, just to follow up, if you need a linux/mac guy to test for you, I'm still willing. =)

This is how auto-seating works (and has always worked).  Since the application doesn't know how many players will show up, the best it can really do is random seating at any open seat.  If it distributed players evenly, that's actually a form of biased seating.  For example, using your example, the best way it could achieve even seating is to do a round-robin methodology: seat the first player at table 1, the second at table 2, the third at table 1, the fourth at table 2, etc.  But that guarantees every 2nd player sits at the same table, and players buying in directly before or after one another won't end up at the same table.

The only thing I can think of for this to "work" is that all players be added to the tournament ahead of time, and all tables/seats be defined ahead of time.  Defining the tables and seats is easier than being able to add all players.  Then again, if you know how the tables and seats will be setup and know who's coming, you can conceivably seat everyone randomly ahead of time.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 15, 2019, 10:11:21 PM
Email license issues to support@thetournamentdirector.net.  FYI, 9 out of 10 times this happens because use of the license on said PC would exceed the 3 concurrent installs (for personal licenses).

Tried the new Beta on my backup machine and it said my licence was not valid. Pretty sure I have a Ver 3 licence. Any advice?
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 15, 2019, 11:12:34 PM
NLAxeman: on second thought, would you just give it another try?  I looked into the code and I think you may have found a sleeper bug that has been in the server-side licensing code for a long time, just exposed by the new version.  I hope when you try again it just works.  Please reply here or email support@thetournamentdirector.net.

Email license issues to support@thetournamentdirector.net.  FYI, 9 out of 10 times this happens because use of the license on said PC would exceed the 3 concurrent installs (for personal licenses).

Tried the new Beta on my backup machine and it said my licence was not valid. Pretty sure I have a Ver 3 licence. Any advice?
Title: Re: 3.7 BETA 1
Post by: Seitz333 on October 16, 2019, 01:18:56 PM
3. I defined two tables of 9 seats each, then added 6 players to a tournament. Then bought them in with autoseating. and there were 4 at one table, and 2 at another. If it were 3 and 3, that'd be understandable, but all at one table would be preferred.

FYI a workaround I have found to keep the tables balanced at pre-tourney buyin time is lets say you are going to have 40 total players. You create 4 tables of 10. Assuming on average you get 32 players ontime and 8 late arrivals. You would leave 2-3 seats at each table set as unavailable. Only make them available when the late player actually arrives and buys into the tourney. This way when ontime players buyin the tables will be as close to balanced as possible when the tourney starts.

I plan to download the new beta today and do some testing tonight. I will run first live tourney with beta version in about 2 weeks.

Chuck
Title: Re: 3.7 BETA 1
Post by: shushs on October 17, 2019, 01:42:47 PM
Thanks for the help.

of course. Not many people can both have a conversation with the author of a tool you use, but provide support/feedback/suggestions. This is great!

So far, it looks pretty good. I did see a few things though.

1. Are you going to include 'The Poker Leaderboard' export again, or is that gone like the wind?


As far as I know, they've been gone for a long time.  Years.

I used their export format for digesting the data and putting it into my own database for analytics. =( I'm almost done porting to the PokerDIY format.


Another tidbit I just ran across... When exporting to the PokerDIY XML structure, the dates, specifically the year, was way off. I checked against the CSV, but that just had a 'Time', not a full 'Date'

Example CSV:
Rank,Nickname,Points,Buyin Cost,Prize Winnings,First Name,Last Name,Email 1,Email 2,Street Address,City,State,Zipcode,Country,Phone 1,Phone 2,Notes,Paid,Bounty Chip,Total Buyin Rake,Buyin Chips,Rebuys,Rebuys Cost,Total Rebuys Rake,Rebuys Chips,Add-ons,Add-ons Cost,Total Add-ons Rake,Add-ons Chips,Total Cost,Total Rake,Chips Bought,Time Out,Round Out,Hitman,Hits,Bounties Won,Bounty Winnings,Total Winnings,Take,Chip Count
5,Austin,0,50,0,,,,,,,,,,,,Scott's Friend,true,10,20,15000,0,0,0,0,0,0,0,0,60,20,15000,2:10:12 pm,2,BeetJunkie,0,0,0,0,-60,15000
1,BeetJunkie,0,50,135,Al,Massey,,,,,,,,,,,true,10,20,15000,0,0,0,0,0,0,0,0,60,20,15000,2:31:59 pm,3,,2,2,20,135,75,15000
...
Example XML:

<?xml version="1.0" encoding="ISO-8859-1"?>
<pXML>
   <MessageInfo>
      <Version>1.0</Version>
      <DocumentType>PokerDIY_Game</DocumentType>
      <Source>TD</Source>
      <SourceVersion>3.7.0-beta.1</SourceVersion>
      <SourceDate>0119-10-15 09:36:11</SourceDate>
   </MessageInfo>
   <Games>
      <Game>
         <League>
            <LeagueID/>
            <ExternalLeagueID/>
            <LeagueName/>
            <Season>
               <SeasonID/>
               <ExternalSeasonID>3ae19ea9-e2ac-4957-b61b-0fdf3faf7ccc</ExternalSeasonID>
               <SeasonName>2019 Points</SeasonName>
            </Season>
         </League>
         <GameID/>
         <ExternalGameID>b5940a44-c94a-4dbd-a7a1-68ab6fb6d55b</ExternalGameID>
         <GameName>The Tournament Director</GameName>
         <GameDescription/>
         <GameComments/>
         <GameStartDate>0119-10-15 08:53:32</GameStartDate>
         <GameEndDate>0119-10-15 09:35:57</GameEndDate>
         <GameTypeID>2</GameTypeID>
         <CurrencySymbol>$</CurrencySymbol>
...
Title: Re: 3.7 BETA 1
Post by: NLAxeman on October 17, 2019, 02:34:20 PM
Hi Corey. Tried it again today and it worked fine. I’ll give it a test over the next few days and see how it goes. Thanks.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 17, 2019, 03:16:37 PM
Good catch.  The code was using getYear().  It used to return the actual current year.  Now, it returns the current year minus 1900.  It is deprecated and shouldn't be used.  I imagine sometime in the past Microsoft made it return the same thing as getFullYear(), so it worked, but Chromium still supports its "correct" value, which caused this issue.  Easy fix.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 17, 2019, 05:33:38 PM
FYI, context menus and hotkeys only work for iframes in HTML screens.  I thought I had added it to both screen types but apparently I did not.  This is actually the way it currently works in version 3.4.3, too, so it's not really a change.  I will add for standard screens.  Hopefully this will eliminate the feeling that the app has stopped responding or has locked up.

Got it this time.  Thanks.  I'll check it out when I can.

I resent from a different email. let me know if you didnt receive it.
Title: Re: 3.7 BETA 1
Post by: Silver Owl on October 18, 2019, 06:36:30 AM
Thanks Corey
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 18, 2019, 06:47:52 AM
Fixed.  Works a lot better using the layout you sent.  Thanks again.

FYI, context menus and hotkeys only work for iframes in HTML screens.  I thought I had added it to both screen types but apparently I did not.  This is actually the way it currently works in version 3.4.3, too, so it's not really a change.  I will add for standard screens.  Hopefully this will eliminate the feeling that the app has stopped responding or has locked up.

Got it this time.  Thanks.  I'll check it out when I can.

I resent from a different email. let me know if you didnt receive it.
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 18, 2019, 02:49:23 PM
2. I had a weird 'bust out before rebuy period was over, and was prompted to rebuy' but subsequent busts were not prompted (still within the window and not exceeding the rebuy quota.

I definitely saw this, but after investigation, I discovered it was only happening when the busting player had reached their max rebuys.  Note that there are 2 quotas: per-player max and a total max.  If the total max is reached, the confirmation dialog will warn you that the max has been reached, but allow you to override it and rebuy players anyway.  If you bust out a single player and that player's individual max has been reached, you won't be prompted, which is what I was seeing (and is correct).  If you bust out multiple players at once, and at least one of them hasn't reached their max, you'll be prompted.

So it appears to be working as expected.  If you are able, could you verify?

I did change this, however.  I decided that the prompt to rebuy NOT appearing because the player reached their max rebuys felt inconsistent.  So if rebuys are enabled, the confirmation will now always appear even if the player(s) busting out has reached their max rebuys.  If you still choose to rebuy, the Rebuy Players dialog does hide ineligible players (but they can be unhidden).  This would at least make the experience consistent, and also convey to the user that the player has reached their max rebuys.
Title: Re: 3.7 BETA 1
Post by: MotoguzziF91 on October 20, 2019, 04:17:18 AM
When exporting the stats as a CSV file, the German umlauts (ö ä ü) and the French special characters (é è ê à ë) and the € sign are not displayed correctly (see Appendix)
no problems with HTML
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 20, 2019, 10:51:42 AM
Can you attach or send me a sample tournament file?

When exporting the stats as a CSV file, the German umlauts (ö ä ü) and the French special characters (é è ê à ë) and the € sign are not displayed correctly (see Appendix)
no problems with HTML
Title: Re: 3.7 BETA 1
Post by: MotoguzziF91 on October 20, 2019, 11:17:59 AM
Hi Corey,
I have sent you a tournament file by mail
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 20, 2019, 08:41:13 PM
Got the email.  Thanks MotoguzziF91.

So when moving to Electron, I had to make some decisions about file encoding.  Previously, the Microsoft API I was using to read and write files essentially took care of encoding.  If the data needed encoding, it was encoded automatically, usually using UTF-16.

With Electron, I am able to encode however I want.  So I went with UTF-8, which is the most popular encoding format.  That file is correctly encoded in UTF-8.  The problem is Excel.  It doesn't recognize the file as being encoded with UTF-8, because the file doesn't have a BOM - or a "byte order marker".  This is a couple of characters at the start of the file that indicate the encoding.  But UTF-8 doesn't require a BOM, and in fact it isn't even recommended it be used.  So the file is encoded correctly, but Excel doesn't recognize it as being encoded at all.  Which is frankly very surprising to me.

If you want to see what I mean, you can use an app like Notepad++.   Open up the CSV file in Notepad++ and you'll see the characters are displayed correctly.  Click on the "Encoding" menu and you'll see that "Encode in UTF-8" is selected, indicating that Notepad++ recognized the file has been encoded in UTF-8.  If you select "Encode in UTF-8-BOM", save the file, and then open it in Excel, you'll see the characters are display correctly now.

So while technically not a bug, I'm not sure yet how I will move forward on this.  I might want to update the code to add the BOM anyway, or give an option in the preferences.

Hi Corey,
I have sent you a tournament file by mail
Title: Re: 3.7 BETA 1
Post by: MotoguzziF91 on October 21, 2019, 03:43:16 AM
Thanks Corey,
This works with notepad ++, it is a bit awkward for me because I work with 4 csv files and macros in excel. But I can live with that.
I have sent you a mail with an error message concerning the stats. Should I post this here in the forum?
Title: Re: 3.7 BETA 1
Post by: MotoguzziF91 on October 21, 2019, 09:28:39 AM
It works also if I export the stats directly into a .txt file and open it in Windows Notepad and save it as a .csv file with UTF-8-BOM encoding
Title: Re: 3.7 BETA 1
Post by: Carlavatky on October 21, 2019, 09:50:03 AM
I went thru the exercise of building an all new Layout with a countdown and a main clock screen on my main work computer that has a widescreen (2560x1080) resolution. It all worked and looked great. When I loaded it into the system in my poker room with 1920x1080 displays and attempt to scale the layout it went widely wonky. I suspect the system just could shrink the display down to that scales for some reason. What is the general rule of thumb when it comes to layout creation like this?
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 21, 2019, 12:20:45 PM
Already fixed the issue with column configurations, so don't worry about posting it.  It will be in beta 2, which should be released later today.

Thanks Corey,
This works with notepad ++, it is a bit awkward for me because I work with 4 csv files and macros in excel. But I can live with that.
I have sent you a mail with an error message concerning the stats. Should I post this here in the forum?
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 21, 2019, 12:47:40 PM
Good question.  The layout has evolved over the years but there are basically a couple of things to keep in mind.

First, the layout sizing is entirely down to the contents, with font size playing a fairly large role.

Second, on the Screen Properties dialog is a checkbox labeled Stretch layout.  If this is not enabled, your layout will be as wide as the contents require, which may mean it doesn't even fill the width or height of your screen.  If this checkbox is enabled, the layout will stretch to the width and height of your screen, if the contents are narrower or shorter than your screen.  Note that the layout is stretched by adding whitespace.  It just fills up the screen, it doesn't change the size of the contents.  This is the original way layouts worked.

Third is Layout Scaling, which was added in version 3.2.  To work properly, the layout must have an "optimal" width and height configured.  Then the entire layout is scaled to the size of your actual screen, keeping the aspect ratio the same.  This doesn't add whitespace, but resizes everything (larger or smaller) to fit your screen.  If your screen is a different aspect ratio than the original layout, some of the contents may bleed off the side or bottom of the screen, or alternatively some whitespace may be present.

Which method you use kind of depends, but there's no "official" guidance.  I would say if the layout was designed for the same resolution or one that's very close, enabling "Stretch layout" will probably be enough.  If it is significantly different, Layout Scaling will probably be better.  Both can be used together, too.  Best advice is to play with the settings a little bit and see how it goes.  If you've created your own layout, to use Layout Scaling you should have the Optimal Resolution set so the scaling feature knows best how to scale your layout.  Press the Settings button on the Layout tab to set it.

For your particular example, your layout was designed for 2560x1080, which is a 21x9 aspect ratio, but you're then using it on screen that has a 16x9 aspect ratio (1920x1080).  Scaling is going to reduce the width to 1920, but it will also reduce the height to keep the aspect ratio intact.  So it will end up at 1920x810, leaving 270 pixels of empty space at the bottom of the screen.  I'm not sure either option is going to work, and you may simply have to make some changes to the layout to get it to fit properly.

I went thru the exercise of building an all new Layout with a countdown and a main clock screen on my main work computer that has a widescreen (2560x1080) resolution. It all worked and looked great. When I loaded it into the system in my poker room with 1920x1080 displays and attempt to scale the layout it went widely wonky. I suspect the system just could shrink the display down to that scales for some reason. What is the general rule of thumb when it comes to layout creation like this?
Title: Re: 3.7 BETA 1
Post by: Carlavatky on October 21, 2019, 08:03:34 PM
Working on a layout and filter cells to "cells not in use on this screen errors with:
ReferenceError: theScreenName is not defined
    at LayoutTab.setCellBoxHandlers (LayoutPage:1638:45)
    at LayoutTab.updateToolbox (LayoutPage:2169:8)
    at LayoutTab.toolboxFilterChange (LayoutPage:912:8)
    at HTMLSelectElement.onchange (kDialog.html:1:3)

AppData: C:\Users\Carl Smith\AppData\Roaming
Arch: ia32
Chrome version: 73.0.3683.121
CPUs: {AMD A6-3400M APU with Radeon(tm) HD Graphics}, {AMD A6-3400M APU with Radeon(tm) HD Graphics}, {AMD A6-3400M APU with Radeon(tm) HD Graphics}, {AMD A6-3400M APU with Radeon(tm) HD Graphics}
Data Folder: C:\Users\Carl Smith\Documents\The Tournament Director 2
Date: 9:01:23 pm 10/21/2019
DB File: C:\Users\Carl Smith\OneDrive\Tournement Director\Data\db\td.db
DB Folder: C:\Users\Carl Smith\OneDrive\Tournement Director\Data\db
Electron version: 5.0.10
Home: C:\Users\Carl Smith
Hostname: Paula-PC
Install Folder: C:\Users\Carl Smith\AppData\Local\Programs\TheTournamentDirector
Language: en-US
License Info: +rN0lGaeRnRHbxWuqtYt5Nf39RxfNc/ZaX6MF4MvqHATcP9Zlnjke/LzpIQYVH8n6TILzed9ySbpMgvN533JJvO4xHQIG1c3tapxJCs5wN0=
Load: 0,0,0
Memory: 943,239,168 / 3,735,969,792
Node version: 12.0.0
OS Release: 10.0.17763
OS Type: Windows_NT
Platform: win32
Preferences File: C:\Users\Carl Smith\Documents\The Tournament Director 2\prefs.sav
Repo Config File: C:\Users\Carl Smith\Documents\The Tournament Director 2\repo.sav
Repo Folder: C:\Users\Carl Smith\OneDrive\Tournement Director\Data
Support Key: CA415DBBE242873D91446LEDE051AT36D4B4E2B7-31DE4129L
TD Language: en-us
TD Patch Level: null
TD Version: 3.7.0-beta.1
Temp directory: C:\Users\CARLSM~1\AppData\Local\Temp
User: Carl Smith
UserData: C:\Users\Carl Smith\AppData\Roaming\TheTournamentDirector
V8 version: 7.3.492.27-electron.0
 
Title: Re: 3.7 BETA 1
Post by: Corey Cooper on October 21, 2019, 11:34:26 PM
Thanks Carlavatky.  Got that one fixed in beta 2.

Beta 2 is out: https://www.thetournamentdirector.net/forums/index.php?topic=5931.0